Install scripts not triggered by 'yarn add'

[thebuilder]

Do you want to request a feature or report a bug?
feature

What is the current behavior?
preinstall and postinstall scripts are not run after using yarn add

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
When using npm the scripts are triggered when you add a new package with npm install.
Yarn triggers it when doing yarn or yarn install, but not when you add new package.
This would also be an issue if you are using other commands like yarn upgrade, that can install new versions.

I think it should follow the same logic - I'm using a postinstall script in a simple project, to build a Webpack DLL file, which should be triggered whenever packages change.

Please mention your node.js, yarn and operating system version.
Yarn: 16.0.0
Node: 6.8.0
Mac Sierra

[darahak]

Looks like it will be solved with this change: #800

[thebuilder]

#800 correctly triggers the install script when using yarn - This is to also enable it for yarn add

[darahak]

Oh you're right, I missed that detail.
I guess add.js needs to run executeLifecycleScript() like in install.js.

Not sure if it's enough to make it work though. I'm discovering the project.

[samccone]

Fixed in #800 please reopen if not.

Thanks for the bug!

[thebuilder]

#800 is only a partial fix. As @darahak suggests, the executeLifeCycleScript() in add.js should match install.js.

[samccone]

ah yes you are right, sorry was too eager in closing.

Any interest in opening a PR to resolve this?

[darahak]

Resolved with #1422 👍