Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.17.0] nested dependencies' bin scripts get hoisted to the root .bin folder #1863

Closed
tomconroy opened this issue Nov 15, 2016 · 4 comments
Closed

Comments

@tomconroy
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?

Yarn 0.17.0 seems to hoist bin scripts to the root module (this behavior varies from 0.16 and npm)

If the current behavior is a bug, please provide the steps to reproduce.

e.g. the main repo's package.json:

{ 
  "dependencies": {
    "thing": "0.1.0"
  }
}

thing:

{
  "dependencies": {
    "nested-thing": "0.1.0"
  }
}

nested-thing:

{
  "bin": {
    "nested-thing": "./bin/nested-thing"
  }
}

The nested-thing script appears here:

node_modules/.bin/nested-thing

What is the expected behavior?

Expect the nested-thing script to be at

node_modules/thing/node_modules/.bin/nested-thing

Please mention your node.js, yarn and operating system version.

node v4.4.7
yarn 0.17.0
OSX 10.11.16

@markstos
Copy link
Contributor

@tomconroy did this cause an error when you ran a command. I think I ran into something like this with 0.17.0 where different depedencies depended on different versions of mkdirp. The result was an ENOENT error when trying to chown the mkdirp binary in the .bin/ directory.

@bestander
Copy link
Member

This was introduced here #1210

@mrkongo
Copy link

mrkongo commented Nov 15, 2016

Urgent fix, please. I can't install 0.16.1 for another bug on Windows 10.

@bestander
Copy link
Member

Fixed, releasing 0.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants