-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn clean breaks tslint due to /lib/test/ folder required for tslint to work #2331
Comments
Many tools treat directories named 'test' as test directories and give them special treatment. Our lib/test directory is not a test directory - it holds code for 'snyk test'. 'yarn clean' is a prime example as it removes all directories named 'test' from a project's node_modules. See: yarnpkg/yarn#2331 See: https://github.com/Snyk/snyk/issues/64
something needs to be done to alleviate this error. yarn clean shouldn't break tslint. tslint issue on yarn - palantir/tslint#1770 |
Any update on the issue? |
You can fix this by removing the |
The docs also state
If the command breaks things, just don't run it. |
This has been mentioned before, but they just keep getting closed. yarn clean is a great feature, but it breaks for tslint (others may also break) because it has src files in the /lib/test/ folder. This is a request to ignore any files in the /src/test or /lib/test or any combination of /"source files folder"/test".
Do you want to request a feature or report a bug?
bug
What is the current behavior?
yarn clean removes necessary files for tslint to work if 'yarn clean' has been used
If the current behavior is a bug, please provide the steps to reproduce.
did:
Fails with:
tslint requires the /tslint/lib/test/ folder to run correctly. Can we get clean to ignore anything under src or lib that has 'test' in it whether it's a folder or a file and any files under a /lib/test/ or /src/test/folder. In this case, it breaks tslint.
What is the expected behavior?
yarn clean to not break tslint.
Please mention your node.js, yarn and operating system version.
node 7.2.1, yarn 0.18.1, Mac OS Sierra 10.12.2
The text was updated successfully, but these errors were encountered: