-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn reports "incorrect peer dependency" for devDependencies of referenced dependencies #2387
Labels
Comments
Same thing happening here.
|
BYK
added a commit
that referenced
this issue
Sep 16, 2017
…4478) **Summary** Fixes #4446, fixes #4433, fixes #2688, fixes #2387. Follow up to #3803. The fix in #3893 was too aggressive, allowing only top-level dependencies to be used in peer dependency resolution which was incorrect. This patch allows resolving peer dependencies from the same or higher levels in the dependency tree. **Test plan** Additional unit and integration tests.
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this issue
Oct 27, 2017
…arnpkg#4478) **Summary** Fixes yarnpkg#4446, fixes yarnpkg#4433, fixes yarnpkg#2688, fixes yarnpkg#2387. Follow up to yarnpkg#3803. The fix in yarnpkg#3893 was too aggressive, allowing only top-level dependencies to be used in peer dependency resolution which was incorrect. This patch allows resolving peer dependencies from the same or higher levels in the dependency tree. **Test plan** Additional unit and integration tests.
@keithbloom Is that a typo? "yarn add v0.18.1" I get "error Couldn't find package "v0.18.1" on the npm registry" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When I install a dependency which has a
devDependency
on already installed package but the versions do not match, the install process reports "Incorrect peer dependency" for that package. This came about when upgrading to webpack 2.If the current behavior is a bug, please provide the steps to reproduce.
Looking at the
yarn.lock
file the extract-text-webpack-plugin entry does not reference webpackbut digging into
package.json
for the extract-text-webpack-plugin it has adevDependency
on an older version of webpack.What is the expected behavior?
I would have thought that yarn would ignore the
devDependencies
of referenced packages or add them to the yarn.lock file so they can be loaded. If not, how can I fix the error messages?Please mention your node.js, yarn and operating system version.
Node.js v6.9.1
Yarn 0.18.1
Windows 10
The text was updated successfully, but these errors were encountered: