Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolatey install fails with too-new Node.JS #2509

Closed
adskdouglaz opened this issue Jan 20, 2017 · 6 comments
Closed

Chocolatey install fails with too-new Node.JS #2509

adskdouglaz opened this issue Jan 20, 2017 · 6 comments

Comments

@adskdouglaz
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?
choco install yarn dies if Node.js version is newer than expected. Running %temp%\chocolatey\yarn\yarnInstall.msi succeeds.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Install Node >= 6.9
  2. choco install yarn

What is the expected behavior?

  • Choco Yarn installer accepts newer versions of Node and continues.

Please mention your node.js, yarn and operating system version.

version
Node.JS 6.9.1
yarn
OS Windows 7 (6.1 build 7601 SP1)
@bestander
Copy link
Member

What is the log output?

@adskdouglaz
Copy link
Author

nodejs.install did not finish successfully. Boo to the chocolatey gods!
-----------------------
[ERROR] [ERROR] Running msiexec with /i "C:\Users\me\AppData\Local\Temp\chocolatey\nodejs.install\nodejs.installInstall.msi" /quiet  was not successful. Exit code was '1603'.
-----------------------

yarn did not finish successfully. Boo to the chocolatey gods!
-----------------------
[ERROR] Checksum for 'C:\Users\me\AppData\Local\Temp\chocolatey\yarn\yarnInstall.msi' did not meet '2D08C4E4E7A6086585EF47307333187A235AA926A211628D3F8C02093FD6FB71' for checksum type 'md5'.
-----------------------

--
Having the time to review this, it looks like it's a checksum failure, not related to installing NodeJS. Though, the NodeJS failure shouldn't be reported that way. (Perhaps that's a bug for the choco-Node guys…)

@Daniel15
Copy link
Member

Hmm strange, the error mentions an MD5 checksum, but we're using SHA256 for Yarn. What version of Chocolatey are you running?

I can't repro on Windows 10:

C:\Users\Daniel
λ choco install yarn
Chocolatey v0.10.3
Installing the following packages:
yarn
By installing you accept licenses for the packages.

nodejs.install v7.3.0 [Approved]
nodejs.install package files install completed. Performing other installation steps.
The package nodejs.install wants to run 'chocolateyInstall.ps1'.
Note: If you don't run this script, the installation will fail.
Note: To confirm automatically next time, use '-y' or consider setting
 'allowGlobalConfirmation'. Run 'choco feature -h' for more details.
Do you want to run the script?([Y]es/[N]o/[P]rint): y

Downloading nodejs.install 64 bit
  from 'https://nodejs.org/dist/v7.3.0/node-v7.3.0-x64.msi'
Progress: 100% - Completed download of C:\Users\Daniel\AppData\Local\Temp\chocolatey\nodejs.install\7.3.0\node-v7.3.0-x64.msi (13.15 MB).
Download of node-v7.3.0-x64.msi (13.15 MB) completed.
Installing nodejs.install...
nodejs.install has been installed.
Environment Vars (like PATH) have changed. Close/reopen your shell to
 see the changes (or in powershell/cmd.exe just type `refreshenv`).
 The install of nodejs.install was successful.
  Software installed as 'msi', install location is likely default.

yarn v0.19.1 [Approved]
yarn package files install completed. Performing other installation steps.
The package yarn wants to run 'chocolateyinstall.ps1'.
Note: If you don't run this script, the installation will fail.
Note: To confirm automatically next time, use '-y' or consider setting
 'allowGlobalConfirmation'. Run 'choco feature -h' for more details.
Do you want to run the script?([Y]es/[N]o/[P]rint): y

Downloading yarn
  from 'https://yarnpkg.com/downloads/0.19.1/yarn-0.19.1.msi'
Progress: 100% - Completed download of C:\Users\Daniel\AppData\Local\Temp\chocolatey\yarn\0.19.1\yarn-0.19.1.msi (5.11 MB).

Download of yarn-0.19.1.msi (5.11 MB) completed.
Hashes match.
Installing yarn...
yarn has been installed.

0
Only an exit code of non-zero will fail the package by default. Set
 `--failonstderr` if you want error messages to also fail a script. See
 `choco -h` for details.
Environment Vars (like PATH) have changed. Close/reopen your shell to
 see the changes (or in powershell/cmd.exe just type `refreshenv`).
 The install of yarn was successful.
  Software installed as 'msi', install location is likely default.

Chocolatey installed 2/2 packages. 0 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

@adskdouglaz
Copy link
Author

Looks like my Chocolatey is out of date: my v0.9.8.29 vs v0.10.3, as you have.

I'll update my local Chocolatey and re-test; then close if I can't repro.

Thanks for the time!

@adskdouglaz
Copy link
Author

Indeed, it looks like the minimum required version of Chocolatey was simply higher than what I had installed. Upgrading to v0.10.3 resolved my issue!

@Daniel15
Copy link
Member

Ah yeah, that'd do it! Looks like Chocolatey added SHA256 in version 0.9.9.9: chocolatey/choco#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants