New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'yarn install --production' does not install transitive dependencies if listed as devDependencies in the project #2819
Comments
Is #761 back again? |
Just hit this with yarn 0.21.3. I have a logger package (B) that depends on bunyan (C), but bunyan is a devDependency of the main package (A). |
Also running 0.21.3 and hitting the same issue as @razor-x |
Same issue here, this just screwed a production build, not good. |
Same here using |
Same here 😖 with latest 0.21.3 installing a lot of devDependecies... |
Does |
…e packages instead of faulty inherit logic. Fixes yarnpkg#2819
This is still present in yarn 0.22.0. Quick one-liner based on OP:
@bestander Could you please check this? There's also an open PR for this, I haven't tested it though #2921 The fact that I can't trust EDIT: I tested with 0.23.0, and it actually prints a warning during
Should the |
Yeah, looks like the bug is present there. I'll investigate now. |
Apparently the logic here is incorrect https://github.com/yarnpkg/yarn/blob/master/src/package-hoister.js#L147 and does not factor top level devDependencies. |
@bestander - already did that, see #2921 |
Awesome, thanks, @blexrob, sorry for missing this. |
…evDependencies list (#2921) * Test for install skipping subdependencies when those are named in root devDependencies * Add 'incompatible' flag to references, use that to ignore incompatible packages instead of faulty inherit logic. Fixes #2819 * Unconditionally mark packages as ignored, hoister now fully corrects transitive uses
…evDependencies list (#2921) (#3065) * Test for install skipping subdependencies when those are named in root devDependencies * Add 'incompatible' flag to references, use that to ignore incompatible packages instead of faulty inherit logic. Fixes #2819 * Unconditionally mark packages as ignored, hoister now fully corrects transitive uses
…evDependencies list (yarnpkg#2921) * Test for install skipping subdependencies when those are named in root devDependencies * Add 'incompatible' flag to references, use that to ignore incompatible packages instead of faulty inherit logic. Fixes yarnpkg#2819 * Unconditionally mark packages as ignored, hoister now fully corrects transitive uses
* Checks that the webpack builds are working properly (#3064) * Fix missing subdeps in production install when those are present in devDependencies list (#2921) * Test for install skipping subdependencies when those are named in root devDependencies * Add 'incompatible' flag to references, use that to ignore incompatible packages instead of faulty inherit logic. Fixes #2819 * Unconditionally mark packages as ignored, hoister now fully corrects transitive uses * replaced deprecated asserts (#3069) * fixing lint (#3070) * Fixes integrity check for --production flag (#3067) * fixed integrity check when running with --production * added test * removed unused var * Remove the dependency on the "rc" module (#3063) * Removes dependency on the "rc" module * Removers shebang-loader, not used anymore * Fixes flow errors * Fixes tests on Windows
Just a comment from my point of view, regarding this warning message (as a response to @bestander's comment):
When I see this after running a If there is a better medium to provide this feedback (new Github issue?), then please let me know. |
@SimenB excellent, thanks for letting me know. Which yarn version will this be released in? |
No idea 😄 |
I just experienced this issue again using v0.24.5. Has there been a regression? |
Please open a new issue with repro steps
…On Fri, 19 May 2017 at 05:43, James Kruth ***@***.***> wrote:
I just experienced this issue again using v0.24.5. Has there been a
regression?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2819 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWFGRWr4mfPbySPNiK3W3wcOxc9-Jks5r7R30gaJpZM4MQdaC>
.
|
Do you want to request a feature or report a bug?
Report a bug
What is the current behavior?
In a project A with a dependency on B and B having a dependency on C,
yarn install --production
wont install C if C is listed as a devDependency of A.npm
does.If the current behavior is a bug, please provide the steps to reproduce.
(note that
sequelize-cli
has a dependency ongulp
:Run
yarn install --production
Try to find
gulp
:ls node_modules/gulp
returns nothing.However, if the package is
yarn install --production
will installgulp
What is the expected behavior?
Transitives production dependencies are always installed, even if the project declares them as devDependencies.
Please mention your node.js, yarn and operating system version.
The text was updated successfully, but these errors were encountered: