Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add end-to-end tests for private packages #4186

Open
BYK opened this issue Aug 16, 2017 · 7 comments
Open

Chore: Add end-to-end tests for private packages #4186

BYK opened this issue Aug 16, 2017 · 7 comments

Comments

@BYK
Copy link
Member

BYK commented Aug 16, 2017

We don't have e2e coverage for private packages which sometimes results in bugs going unnoticed until we make a release. We should have at least one smoke test for a very simple private package on NPM and private repo on GitHub or Bitbucket.

@BYK BYK mentioned this issue Aug 16, 2017
3 tasks
@onurtemizkan
Copy link
Contributor

I can take this one if it's ok

@BYK
Copy link
Member Author

BYK commented Aug 16, 2017

@onurtemizkan go ahead and take it! The main issue here is who will own the test-related private packages? Looks like we can create a private repo under yarnpkg org and probably do the same with scoped packages on NPM but I'd rather hear what @bestander and @Daniel15 has to say about this first. Also may be @cpojer.

@bestander
Copy link
Member

bestander commented Aug 16, 2017 via email

@Daniel15
Copy link
Member

Daniel15 commented Aug 17, 2017

I thought we already had an issue for this?

@BYK
Copy link
Member Author

BYK commented Aug 17, 2017

@Daniel15 - I couldn't find it. Feel free to close this or the other as a duplicate if you bump into it.

@bestander
Copy link
Member

There was one but I did not create it, so can't find it.

@avindra
Copy link

avindra commented Oct 5, 2017

Relevant breaking issue right now with private registry libs completely failing to install

#4157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants