Yarn install peerDependencies of no-hoisted packages' dependencies wrongly

[wuct]

Do you want to request a feature or report a bug?
A bug.

What is the current behavior?

Let's say we are working on a big workspace project and all sub-projects are using react@15. We have the following setting in the root package.json:

"workspaces": {
  "packages": ["a", "b"]
}

After react@16 released, we want to migrate our project incrementally and we want to do it for b first, so we update the workspaces to:

"workspaces": {
  "packages": ["a", "b"],
  "nohoist": ["b/**"]
}

This setup can help us avoid getting different versions of reacts in b. For example, if we are using react-redux@5 in both a and b, the current result is:

├── node_modules
│   ├── react@15
│   └── react-redux@5
│     
├── a
│   └── node_modules
├── b
│   └── node_modules
│       ├── react@16
│       └── react-redux@5
│           └── node_modules
│               └── react@15

where b/node_modules/react-redux/node_modules/react is wrong.

What is the expected behavior?

The expected result is:

├── node_modules
│   ├── react@15
│   └── react-redux@5
│     
├── a
│   └── node_modules
├── b
│   └── node_modules
│       ├── react@16
│       └── react-redux@5

Please mention your node.js, yarn and operating system version.

yarn: 1.9.2
node: 8.11.2
npm: 5.6.0
os: macOS 10.13.5

[wuct]

I think the bug is from this function, but there is no unit test for this file so it's hard to trace code. @BYK could you provide some insight into how this function works?

[SebastianBogado]

+1 @wuct . Same bug as here #5978

[wuct]

I've updated the comment to follow the template.

[wuct]

@SebastianBogado I'm not using lerna, so I guess the bug is from yarn.

[SebastianBogado]

@wuct 100% agreed

[paul-soporan]

Closing as fixed in v2.

https://yarnpkg.com/getting-started/migration