Add automatic check for updates that nags the user when there's a new version available #1429

sebmck · 2016-10-25T10:40:05Z

No description provided.

… version available - fixes #1138

Daniel15 · 2016-10-25T15:32:43Z

Awesome! I'll take a look at this later today or tomorrow :)

jamiebuilds · 2016-10-25T16:09:23Z

src/cli/commands/install.js

+
+  async _checkUpdate(): Promise<void> {
+    let latestVersion = await this.config.requestManager.request({
+      url: 'https://yarnpkg.com/latest-version',


We need to better automate this getting updated

Yeah, I'm going to have a webhook that runs when releases are updated, or just a cronjob. The tricky thing is that we can't bump the version number until we verify that all files are attached to the release, and the Windows installer is attached separately from everything else (as it's built on AppVeyor).

Daniel15 · 2016-10-25T16:47:29Z

src/cli/commands/install.js

+
+  checkUpdate() {
+    if (!process.stdout.isTTY || isCI) {
+      // don't show upgrade dialog on CI or non-TTY terminals


I think this is still valuable for non-TTY environments. Why should we avoid showing a notice about Yarn being outdated just because the user is piping the output to a file, for example?

Daniel15 · 2016-10-25T16:48:35Z

src/reporters/lang/en.js

@@ -72,6 +72,10 @@ const messages = {
  unexpectedError: 'An unexpected error occurred, please open a bug report with the information provided in $0.',
  jsonError: 'Error parsing JSON at $0, $1.',

+  yarnOutdated: "Your current version of Yarn is out of date. The latest version is $0 while you're on $1.",
+  yarnOutdatedInstaller: 'To upgrade, download the latest installer at $0.',
+  yarnOutdatedCommand: 'To upgrade, run $0.',


Let's put the command on its own separate line. @sindresorhus said:

Having the command on a separate line makes it easier to copy-paste for users.
#1138 (comment)

Daniel15 · 2016-10-25T16:55:46Z

src/cli/commands/install.js

+ */
+
+function getUpdateCommand(): ?string {
+  // Tarball install


Instead of doing this inferrence, let's save a token somewhere as part of the packaging process. @cpojer said:

Can we somehow add a token to every build indicating the install method? I think that's way better than any sort of inference we might do.

My idea for that was to add an extra installationMethod field to package.json when building the packages. For example, something like this would be bundled in the Debian package:

{ "name": "yarn", "version": "0.16.2", "installationMethod": "deb",

What do you think? #942 is the issue that covers(-ish) that. If you agree that that's a good idea, let's complete #942 before this one, and then rebase this on top of that.

The main issue I see with inference is when the user has multiple installations of Yarn. That's a bit silly, but they might have installed via the tarball and then also done npm install -g yarn for some reason. The instructions might tell them to update the wrong one.

Daniel15 · 2016-10-25T16:56:29Z

src/cli/commands/install.js

+
+function getUpdateCommand(): ?string {
+  // Tarball install
+  if (fs2.existsSync(path.join(userHome, '.yarn'))) {


Isn't ~/.yarn where user settings are stored?

Daniel15 · 2016-10-25T16:57:28Z

src/cli/commands/install.js

+
+function getUpdateInstaller(): ?string {
+  // Windows
+  if (fs2.existsSync('C:/Program Files/Yarn') || fs2.existsSync('C:/Program Files (x86)/Yarn')) {


This won't work as the user can select any directory during installation. Using the environment variable (%ProgramFiles%\Yarn) is better, but still not 100% accurate. They might decide to install it to c:\apps\Yarn for example. There's a registry key we can read to get the path, but modifying package.json to have "installationMethod": "msi" as part of the build process would be the easiest thing to do, then we can just require(__dirname + 'package.json').installationMethod

Daniel15 · 2016-10-25T16:59:08Z

src/cli/commands/install.js

+        } else {
+          const installer = getUpdateInstaller();
+          if (installer) {
+            this.reporter.info(this.reporter.lang('yarnOutdatedInstaller', installer));


Optional, but can we use something like boxen (or just render the ANSI codes ourself) to render a fancy box around it, like update-notifier does?

References yarnpkg#1139, yarnpkg#942, yarnpkg#1429, yarnpkg#1138

Daniel15 · 2016-10-30T07:56:38Z

See #1557. You should be able to build on that and just have a map of installationMethod => instructions 😄

* Add installationMethod property to package.json References #1139, #942, #1429, #1138 * Make set-installation-method.js executable

# Conflicts: # package.json # src/config.js # yarn.lock

Daniel15 · 2016-11-04T04:17:50Z

scripts/install-latest.sh

-    printf "$red> Remove it (rm -rf ~/.yarn) and run this script again.$reset\n"
-    exit 0
+    if [ -n `which yarn` ]; then
+      LATEST_VERSION=`curl https://yarnpkg.com/latest-version`


This may need to handle the --nightly flag. We have this in yarn_get_tarball:

if [ "$1" = '--nightly' ]; then url=https://nightly.yarnpkg.com/latest.tar.gz else url=https://yarnpkg.com/latest.tar.gz fi

You can use https://nightly.yarnpkg.com/latest-tar-version to get the latest nightly version.

Daniel15 · 2016-11-04T04:18:15Z

src/cli/commands/install.js

+    return 'curl -o- -L https://yarnpkg.com/install.sh | bash';
+  }
+
+  if (YARN_INSTALL_METHOD === 'homebrwe') {


Typo: "homebrwe" -> "homebrew"

Daniel15 · 2016-11-04T04:18:25Z

src/cli/commands/install.js

+  }
+
+  if (YARN_INSTALL_METHOD === 'deb') {
+    return 'sudo apt-get updat e&& sudo apt-get install yarn';


Typo: "updat e" -> "update"

Daniel15 · 2016-11-04T04:19:36Z

scripts/install-latest.sh

+      if [ "$LATEST_VERSION" -eq "$YARN_VERSION" ]; then
+        printf "$green> Yarn is already at the latest version.$reset\n"
+      else
+        rm -rf "$HOME/.yarn"


2scary4me, maybe warn the user before doing this.

"A newer version of Yarn is available, do you want to delete the existing version and upgrade? (Y/N)"

Also won't this blow away their config? Or is that stored elsewhere?

Daniel15 · 2016-11-04T04:20:31Z

src/cli/commands/install.js

+  if (YARN_INSTALL_METHOD === 'npm') {
+    return 'npm upgrade --global yarn';
+  }
+


Also add Chocolatey: choco upgrade yarn

Daniel15 · 2016-11-04T04:21:24Z

src/cli/commands/install.js

+      return;
+    }
+
+    // don't bug for updates on tagged releases


Hmm, I wonder if we should bug on nightly builds?

Daniel15 · 2016-11-04T04:22:12Z

src/reporters/lang/en.js

@@ -77,6 +77,10 @@ const messages = {
  jsonError: 'Error parsing JSON at $0, $1.',
  noFilePermission: "We don't have permissions to touch the file $0.",

+  yarnOutdated: "Your current version of Yarn is out of date. The latest version is $0 while you're on $1.",
+  yarnOutdatedInstaller: 'To upgrade, download the latest installer at $0.',


This is totally optional, but we could download the installer and run it for the user. Maybe we'll hold off on that for now and do it as an enhancement!

Daniel15 · 2016-11-04T04:22:33Z

Thanks @kittens! This looks pretty good to me. Just some small comments inline 😄

rpunkfu · 2016-11-08T23:53:50Z

src/cli/commands/install.js

 const path = require('path');
+const fs2 = require('fs');
+
+const {verison: YARN_VERSION, installationMethod: YARN_INSTALL_METHOD} = require('../../../package.json');


possibly typo verison

bestander · 2016-11-14T13:50:14Z

ping @kittens

# Conflicts: # src/cli/commands/install.js

sebmck mentioned this pull request Oct 25, 2016

Add yarn version check on startup #1138

Closed

sebmck force-pushed the update-check branch from 5c0c4de to e864da9 Compare October 25, 2016 10:52

Add automatic check for updates that nags the user when there's a new…

e864da9

… version available - fixes #1138

jamiebuilds reviewed Oct 25, 2016

View reviewed changes

Daniel15 requested changes Oct 25, 2016

View reviewed changes

Daniel15 added a commit to Daniel15/yarn that referenced this pull request Oct 30, 2016

Add installationMethod property to package.json

fff6c03

References yarnpkg#1139, yarnpkg#942, yarnpkg#1429, yarnpkg#1138

Daniel15 added a commit to Daniel15/yarn that referenced this pull request Oct 30, 2016

Add installationMethod property to package.json

bbafb94

References yarnpkg#1139, yarnpkg#942, yarnpkg#1429, yarnpkg#1138

Daniel15 mentioned this pull request Oct 30, 2016

Add installationMethod property to package.json #1557

Merged

sebmck pushed a commit that referenced this pull request Nov 1, 2016

Add installationMethod property to package.json (#1557)

6ca0723

* Add installationMethod property to package.json References #1139, #942, #1429, #1138 * Make set-installation-method.js executable

Sebastian McKenzie added 4 commits November 3, 2016 11:30

Merge branch 'master' into update-check

6e707f3

# Conflicts: # package.json # src/config.js # yarn.lock

remove self-update

6c41fee

add support for updating yarn to tarball installer

e2aa1d6

use new installationMethod package.json value to output update command

f4c2fe6

Daniel15 reviewed Nov 4, 2016

View reviewed changes

src/cli/commands/install.js

return;

}

// don't bug for updates on tagged releases

Copy link

Member

Daniel15 Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder if we should bug on nightly builds?

Daniel15 reviewed Nov 4, 2016

View reviewed changes

rpunkfu reviewed Nov 8, 2016

View reviewed changes

Sebastian McKenzie added 3 commits November 14, 2016 16:28

Merge branch 'master' into update-check

6e89da4

# Conflicts: # src/cli/commands/install.js

address comments from @Daniel15

0e81f3f

remove self update tests

ef68b73

bestander merged commit 15d0112 into master Nov 14, 2016

wyze deleted the update-check branch November 14, 2016 20:25

kevinzwhuang mentioned this pull request Nov 14, 2016

Fix version key typo on install.js #1828

Merged

busches mentioned this pull request Dec 6, 2016

yarn self-update should update using the same installation method originally used #1139

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add automatic check for updates that nags the user when there's a new version available #1429

Add automatic check for updates that nags the user when there's a new version available #1429

sebmck commented Oct 25, 2016

Daniel15 commented Oct 25, 2016

jamiebuilds Oct 25, 2016

Daniel15 Oct 25, 2016

Daniel15 Oct 25, 2016

Daniel15 Oct 25, 2016

Daniel15 Oct 25, 2016

Daniel15 Oct 25, 2016

Daniel15 Oct 25, 2016 •

edited

Daniel15 Oct 25, 2016

Daniel15 commented Oct 30, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 Nov 4, 2016

Daniel15 commented Nov 4, 2016

rpunkfu Nov 8, 2016

bestander commented Nov 14, 2016

Add automatic check for updates that nags the user when there's a new version available #1429

Add automatic check for updates that nags the user when there's a new version available #1429

Conversation

sebmck commented Oct 25, 2016

Daniel15 commented Oct 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daniel15 Oct 25, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daniel15 commented Oct 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daniel15 commented Nov 4, 2016

Choose a reason for hiding this comment

bestander commented Nov 14, 2016

Daniel15 Oct 25, 2016 •

edited