Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load GPG key from URL rather than keyserver #1598

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Conversation

Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Nov 1, 2016

Summary
Loads GPG key from a URL we host, rather than a keyserver. This will hopefully make builds less flaky (they won't fail when the keyserver has issues)

I tried https but it didn't work:

gpgkeys: protocol 'https' not supported
gpg: no handler for keyserver scheme 'https'
gpg: WARNING: unable to fetch URI https://dl.yarnpkg.com/debian/pubkey.gpg: keyserver error

Test plan

Tested the command locally. Will check CircleCI build.

Removes one point of failure (flaky GPG key servers)
@Daniel15
Copy link
Member Author

Daniel15 commented Nov 1, 2016

CircleCI failure is unrelated - It's a flaky unit test. Going to merge this since adding the GPG key works fine.

@Daniel15 Daniel15 merged commit d2865a9 into master Nov 1, 2016
@bestander bestander deleted the Daniel15-patch-2 branch November 6, 2016 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant