Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request authentication for scoped private registry tarballs #1666

Merged
merged 6 commits into from Nov 19, 2016
Merged

Fix request authentication for scoped private registry tarballs #1666

merged 6 commits into from Nov 19, 2016

Commits on Nov 19, 2016

  1. Fix request authentication for scoped private registry tarballs 

    Yarn correctly sends authorization headers when resolving metadata, but
when it's time to download the tarballs, it calls registry.request
with a full tarball url. This causes the getRegistry() function to
incorrectly return the DEFAULT_REGISTRY url which means the authorization
headers are no longer sent. The response in this case is a JSON error
object instead of a tarball file. Untaring fails with "invalid tar file"
    @KidkArolis
    KidkArolis committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    1c3fccf View commit details
    Browse the repository at this point in the history

  2. Don't assume anything about the registry URL, read registries from co… 

    …nfig
    @KidkArolis
    KidkArolis committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    7849330 View commit details
    Browse the repository at this point in the history

  3. Add a test for installing private packages requiring authentication

    @KidkArolis
    KidkArolis committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    f551643 View commit details
    Browse the repository at this point in the history

  4. Change the authed package testing strategy to be more local

    @KidkArolis
    KidkArolis committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    0092b6c View commit details
    Browse the repository at this point in the history

  5. Include non scoped registries in available registries list

    @KidkArolis
    KidkArolis committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    4469ce8 View commit details
    Browse the repository at this point in the history

  6. Unnest the authed pkg test, use FlowFixMe for afterEach

    @KidkArolis
    KidkArolis committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    6be4745 View commit details
    Browse the repository at this point in the history