Remove duplicate --production flag from licenses #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to add --production flag explicitly to licenses as it's already a global flag. This also fixes the --production flag from appearing twice when running `yarn help licenses`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is code currently that explicitly adds a
--productionflag option to thelicensescommand. This is unneeded and results in duplicate output of the flag when runningyarn help licensesTest plan
Running
bin\yarn.cmd licenses lsandbin\yarn.cmd licenses ls --productionresult in the same results using the latest yarn. There currently are no tests aroundlicenses.jsand removing code seems like the wrong time to add them.