Fix AppVeyor deployment webhook #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the AppVeyor deployment webhook. AppVeyor wasn't actually building the tags, it was just building the stable branch. This meant that the deployment script wasn't actually running, as
appveyor_repo_tagwas nevertrue.We don't want to deploy every individual commit to the stable branch, we only want to deploy tags. I've switched the branch list to only build master and tags (instead of master and stable branches), and updated the deployment webhook to be called for tags.
Test plan
Tested something similar on my fork: https://ci.appveyor.com/project/Daniel15/yarn/build/job/dpyvcc0p88ss9se6