Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Roadrunner #3079

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Remove Roadrunner #3079

merged 1 commit into from
Apr 8, 2017

Conversation

Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Apr 8, 2017 •
edited
Loading

Summary
Now that we're including the bundled .js file in the tarball, we don't really need Roadrunner. @bestander suggested removing it in #3030:

What do you think of getting rid of roadrunner as well? The extra cache layer for people who run from master branch does not make much impact.

Test plan
./bin/yarn install, it worked as expected.

Closes #3075, #3037, #2959

bestander
bestander approved these changes Apr 8, 2017
View reviewed changes
Copy link
Member

@bestander bestander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's simplify a bit.
I keep seeing roadrunner issues on CI from time to time.

@Daniel15 Daniel15 merged commit e086476 into yarnpkg:master Apr 8, 2017
@Daniel15 Daniel15 deleted the meep-meep branch April 8, 2017 21:55
@DanBuild DanBuild mentioned this pull request Apr 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestander bestander bestander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Daniel15 @bestander