Fix: make sure all extracted tarballs are r/w enabled #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not using the regular dir |
That's fair. Honestly, I just wanted to use the named options instead of Unix file permission codes, that's why. If you think this is unsafe, I can change it. Actually, I can imagine a scenario where a private package should not be readable by other users so I'll go ahead and use your suggestion instead. |
arcanis
approved these changes
Sep 4, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
* Fix: make sure all extracted tarballs are r/w enabled **Summary** Fixes: yarnpkg#992. This issue was supposed to be fixed by yarnpkg#2826 but it was not setting directory permissions wide enough. This patch uses the `readable` and `writable` options provided by the `tar-fs` package which essentially sets everything to `0o777`. **Test plan** N/A * fewer perms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #992. This issue was supposed to be fixed by #2826 but it
was not setting directory permissions wide enough. This patch uses
the
readableandwritableoptions provided by thetar-fspackage which essentially sets everything to
0o777.Test plan
N/A