-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: More resillient global and cache folder determination #4325
Commits on Sep 6, 2017
-
Fix: Make sure global prefix folder is writeable when selecting it
**Summary** Fixes #4320 and fixes #4323. We were using `fs.access` when selecting the global prefix folder automatically which only checks for permissions but not actual writeability. This caused issues on Heroku where one of our first tries had the correct permissions but was on a read-only file system. **Test plan** Existing cache folder fallback tests should be enough for now. We should move the core of those tests for the newly added `fs.getFirstWriteableFolder` method.
Configuration menu - View commit details
-
Copy full SHA for fa98ad9 - Browse repository at this point
Copy the full SHA fa98ad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b48aa - Browse repository at this point
Copy the full SHA f4b48aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1c43cc - Browse repository at this point
Copy the full SHA b1c43ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b3542 - Browse repository at this point
Copy the full SHA a9b3542View commit details -
Configuration menu - View commit details
-
Copy full SHA for e478af9 - Browse repository at this point
Copy the full SHA e478af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcb953c - Browse repository at this point
Copy the full SHA dcb953cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5685843 - Browse repository at this point
Copy the full SHA 5685843View commit details -
5
Configuration menu - View commit details
-
Copy full SHA for 9576dbd - Browse repository at this point
Copy the full SHA 9576dbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9c0fb8 - Browse repository at this point
Copy the full SHA b9c0fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73c61ae - Browse repository at this point
Copy the full SHA 73c61aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e6b708 - Browse repository at this point
Copy the full SHA 1e6b708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54c7581 - Browse repository at this point
Copy the full SHA 54c7581View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86de168 - Browse repository at this point
Copy the full SHA 86de168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89d52ce - Browse repository at this point
Copy the full SHA 89d52ceView commit details
Commits on Sep 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f21abfb - Browse repository at this point
Copy the full SHA f21abfbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.