Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: More resillient global and cache folder determination #4325

Merged
merged 15 commits into from
Sep 7, 2017
Merged

Commits on Sep 6, 2017

  1. Fix: Make sure global prefix folder is writeable when selecting it

    **Summary**
    
    Fixes #4320 and fixes #4323. We were using `fs.access` when selecting
    the global prefix folder automatically which only checks for permissions
    but not actual writeability. This caused issues on Heroku where one of
    our first tries had the correct permissions but was on a read-only
    file system.
    
    **Test plan**
    
    Existing cache folder fallback tests should be enough for now. We should
    move the core of those tests for the newly added `fs.getFirstWriteableFolder`
    method.
    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    fa98ad9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4b48aa View commit details
    Browse the repository at this point in the history
  3. Better error message

    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b1c43cc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9b3542 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e478af9 View commit details
    Browse the repository at this point in the history
  6. Fix DESTDIR typo

    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    dcb953c View commit details
    Browse the repository at this point in the history
  7. Fix skippedFolder error

    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    5685843 View commit details
    Browse the repository at this point in the history
  8. 5 Configuration menu
    Copy the full SHA
    9576dbd View commit details
    Browse the repository at this point in the history
  9. Don't use process.execPath

    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b9c0fb8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    73c61ae View commit details
    Browse the repository at this point in the history
  11. flow type

    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    1e6b708 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    54c7581 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    86de168 View commit details
    Browse the repository at this point in the history
  14. Keep the old behavior

    BYK committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    89d52ce View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Update fs.js

    arcanis committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    f21abfb View commit details
    Browse the repository at this point in the history