fix(config): Don't override registry with undefined by default
#4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Follow up to #4238. We were always passing the `registry` key in registry overrides but its value was `undefined` when an override was not in place. `Object.assign` doesn't care about that though so we were overriding the registry all the time, mostly with `undefined`. **Test plan** Added new test case.
rally25rs
approved these changes
Oct 5, 2017
|
@rally25rs thanks a lot for reporting it! (and finding the root cause) |
arcanis
approved these changes
Oct 6, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…npkg#4643) **Summary** Follow up to yarnpkg#4238. We were always passing the `registry` key in registry overrides but its value was `undefined` when an override was not in place. `Object.assign` doesn't care about that though so we were overriding the registry all the time, mostly with `undefined`. **Test plan** Added new test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #4238. We were always passing the
registrykey inregistry overrides but its value was
undefinedwhen an overridewas not in place.
Object.assigndoesn't care about that thoughso we were overriding the registry all the time, mostly with
undefined.Test plan
Added new test case.