fix(resolution): use registry latest if it satisfies requested semver range #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… range Fixes yarnpkg#3560 **Summary** Mimic behavior in NPM; use the `latest` version in registry if it satisfies the semver range requests. Otherwise fallback to `semver.maxSatisfying()` **Test Plan** Added unit test to verify behavior.
|
This change will increase the build size from 9.94 MB to 9.94 MB, an increase of 554 bytes (0%)
|
neonowy
added a commit
to neonowy/yarn
that referenced
this pull request
Oct 30, 2017
BYK
approved these changes
Oct 31, 2017
__tests__/commands/add.js
Outdated
| @@ -986,3 +986,42 @@ test.concurrent('preserves unaffected bin links after adding to workspace packag | |||
| expect(await fs.exists(`${config.cwd}/packages/workspace-2/node_modules/.bin/workspace-1`)).toEqual(true); | |||
| }); | |||
| }); | |||
|
|
|||
| test.concurrent('installs "latest" instead of maxSatisfying if it satisfies requested pattern', (): Promise<void> => { | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
Can you just disable the relevant warning with /* eslint-disable rule-name */ instead of a blanket disable statement in case the enable part goes away?
Or ideally, we wouldn't need this at all since you can use https://git.io/ to get short GitHub URLs ;)
arcanis
approved these changes
Oct 31, 2017
arcanis
pushed a commit
that referenced
this pull request
Oct 31, 2017
neonowy
added a commit
to neonowy/yarn
that referenced
this pull request
Oct 31, 2017
arcanis
pushed a commit
that referenced
this pull request
Oct 31, 2017
…one (#4797) * fix(info): Use version from `latest` dist-tag instead of the highest one Fixes #3947. By default, package `version` was set by sorting all the versions and getting the highest one. Now it's provided via package `latest` dist-tag. * Fix linter issues by shortening the test description * Manually mock request * Add scenario comment from #4804
calvinhuang
pushed a commit
to calvinhuang/yarn
that referenced
this pull request
Nov 9, 2017
… range (yarnpkg#4804) * fix(resolution): use registry latest if it satisfies requested semver range Fixes yarnpkg#3560 **Summary** Mimic behavior in NPM; use the `latest` version in registry if it satisfies the semver range requests. Otherwise fallback to `semver.maxSatisfying()` **Test Plan** Added unit test to verify behavior. * fix eslint line len, additional field check
calvinhuang
pushed a commit
to calvinhuang/yarn
that referenced
this pull request
Nov 9, 2017
…one (yarnpkg#4797) * fix(info): Use version from `latest` dist-tag instead of the highest one Fixes yarnpkg#3947. By default, package `version` was set by sorting all the versions and getting the highest one. Now it's provided via package `latest` dist-tag. * Fix linter issues by shortening the test description * Manually mock request * Add scenario comment from yarnpkg#4804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3560.
Related PR: #4797.
Mimic behavior in NPM; use the
latestversion in registry if itsatisfies the semver range requests.
Otherwise fallback to
semver.maxSatisfying()NPM source that specifies this behavior is: https://github.com/npm/npm/blob/d46015256941ddfff1463338e3e2f8f77624a1ff/lib/utils/pick-manifest-from-registry-metadata.js#L10-L14
I believe this is OK directly in the NPM resolver, as other resolvers may not have a "latest" tag or dist-tags in general (for example, I don't believe git-resolver has this metadata to check).
Test Plan
Added unit test to verify behavior.