-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linking): Handle missing package when using --ignore-optional #5059
Changes from all commits
0d996fb
70e5d5f
abbd567
f847983
474be64
231ca5e
a661b2d
c607be2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"name": "normal-dep", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"sub-dep": "file:../sub-dep", | ||
"normal-sub-dep": "file:../normal-sub-dep" | ||
}, | ||
"optionalDependencies": { | ||
"optional-sub-dep": "file:../optional-sub-dep" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "normal-sub-dep", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"normal-sub-sub-dep": "file:../normal-sub-sub-dep" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "normal-sub-sub-dep", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"sub-dep-2": "file:../sub-dep-2" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"name": "optional-dep", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"sub-dep": "file:../sub-dep", | ||
"sub-dep-2": "file:../sub-dep-2" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "optional-sub-dep", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"normal-sub-sub-dep": "file:../normal-sub-sub-dep" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "sub-dep-2", | ||
"version": "0.0.0", | ||
"dependencies": { | ||
"sub-sub-dep": "file:../sub-sub-dep" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "sub-dep", | ||
"version": "0.0.0" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "sub-sub-dep", | ||
"version": "0.0.0" | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -124,3 +124,5 @@ export const VERSION_COLOR_SCHEME: {[key: string]: VersionColor} = { | |||||
}; | ||||||
|
||||||
export type VersionColor = 'red' | 'yellow' | 'green' | 'white'; | ||||||
|
||||||
export type RequestHint = 'dev' | 'optional' | 'resolution' | 'workspaces'; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't see other hints being used anywhere else. Do we need anything other than There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
yarn/src/cli/commands/install.js Line 281 in 5ef113f
and yarn/src/cli/commands/install.js Line 379 in 5ef113f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make
hint
optional here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of
yarn/src/cli/commands/install.js
Line 327 in 5ef113f
Not sure if
constants.RequestHint | null
or?constants.RequestHint
is preferred(?) Or maybe add aproduction
hint and always requirehint
?