Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: yarn tag list prompted user for credentials removed #5373

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

seansabour
Copy link
Contributor

Summary
This is a bug fix for issue #5325 that caused yarn tag list to prompt user for credentials. Running npm dist-tag ls will not prompt for credentials.

Test plan
I have not tested the code yet due to an issue with babel-eslint:

yarn run lint
yarn run v1.4.1
$ eslint . && flow check
Cannot read property 'type' of undefined
TypeError: Cannot read property 'type' of undefined
    at isForInRef (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/rules/no-unused-vars.js:406:24)
    at variable.references.some.ref (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/rules/no-unused-vars.js:443:21)
    at Array.some (<anonymous>)
    at isUsedVariable (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/rules/no-unused-vars.js:442:40)
    at collectUnusedVariables (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/rules/no-unused-vars.js:565:26)
    at Program:exit (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/rules/no-unused-vars.js:617:36)
    at listeners.(anonymous function).forEach.listener (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.leaveNode (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/node-event-generator.js:303:14)
    at CodePathAnalyzer.leaveNode (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:630:23)
    at Traverser.leave [as _leave] (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/linter.js:1020:32)
    at Traverser._traverse (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/traverser.js:155:18)
    at Traverser.traverse (/Users/ssabour/Desktop/development/yarn/node_modules/eslint/lib/util/traverser.js:115:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Some searching brought me to this issue eslint/eslint#9767

P.S my first contribution to open source, so sorry for any misunderstanding

@arcanis arcanis merged commit ef2b439 into yarnpkg:master Feb 28, 2018
@arcanis
Copy link
Member

arcanis commented Feb 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants