Fix test for yarn licenses generate-disclaimer output
#5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command writes it's output with console.log(), intentionally. The tests should capture that output and verify that it's correct.
arcanis
approved these changes
Feb 28, 2018
|
Sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a test that attempts to test that license files are show correctly for
yarn licenses generate-disclaimer. The test currently just prints the license files to the console and doesn't verify what was printed. This pull request modifies the test to not show unwanted output during testing and to actually test that the output is correct.Implementation
The normal method of capturing output isn't sufficient to capture the output of
yarn licenses generate-disclaimer, since that command intentionally usesconsole.log()directly. Because of this a special helper function is used that mocksconsole.log()and lets the test verify what was written.Test plan
The
licenses.js.snap, which is used to verify the commands output, now contains the license text we expect to be printed. The test passes using this .snap file.Additional change
I also renamed the "lists all licenses of the dependencies with the --json argument" test in the same file because it doesn't seem to involve any --json argument.