fix(console-reporter): Fix issue where tree logger was ignoring --silent/-s flag #5722
Conversation
|
cc/ @rally25rs |
There was a problem hiding this comment.
Hey, thanks for the patch! Can you add tests for this fix here: https://github.com/yarnpkg/yarn/blob/master/__tests__/reporters/console-reporter.js?
|
To add a test for I can lend a hand with that if needed. |
|
@BYK @rally25rs - can you take a look at those changes? |
| @@ -16,7 +16,8 @@ type MockCallback = (reporter: Reporter, opts: Object) => ?Promise<void>; | |||
| export default function<T>( | |||
| Reporter: Function, | |||
| interceptor: Interceptor<T>, | |||
| prepare?: (reporter: Reporter) => any, | |||
| prepare?: ?(reporter: Reporter) => any, | |||
| opts?: Object, | |||
There was a problem hiding this comment.
nit: this can be extraOpts and then you can avoid the opts -> newOpts rename.
There was a problem hiding this comment.
Yeah, I was thinking that too. But thought it would have been preferred to keep the argument named as opts. Let me know if you want to change though 馃槃
| @@ -266,3 +266,41 @@ test('close', async () => { | |||
| }), | |||
| ).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| test('ConsoleReporter.log is silent when isSilent is true', async () => { | |||
There was a problem hiding this comment.
Drop the 'ConsoleReporter.' prefix please :)
There was a problem hiding this comment.
Scratch that, just realized the whole file does this.
BYK
changed the title
Summary
This PR fixes #5721 where
upgradewas not being silent when the--silent/-sflags were provided. It still printed the tree. 馃枿馃尦Test plan
Added two new test cases.
Manual CLI tests:
Before:
After: