-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(node4): Drop Node 4 builds which has expired #5736
Conversation
Thanks for all the fish Node 4, you won't be missed.
scripts/build-deb.sh
Outdated
@@ -13,7 +13,7 @@ ensureAvailable lintian | |||
ensureAvailable rpmbuild | |||
|
|||
PACKAGE_TMPDIR=tmp/debian_pkg | |||
VERSION=`./artifacts/yarn-legacy-* --version` | |||
VERSION=`./artifacts/yarn-* --version` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work because ./artifacts/yarn-......tar.gz
also matches this glob:
+ PACKAGE_TMPDIR=tmp/debian_pkg
++ ./artifacts/yarn-1.6.0.js ./artifacts/yarn-v1.6.0.tar.gz --version
error Command "./artifacts/yarn-v1.6.0.tar.gz" not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will see what we can do about it.
Approve but this is a major change, right? We probably should wait until we want to release a v2 before merging it. |
|
Yeah, I was gonna ask about this. I think this deserves a major version bump :( |
Closing as I don't think we'll be releasing another major version of the legacy Yarn at all as Yarn v2 is going along quite well :) |
Summary
Thanks for all the fish Node 4, you won't be missed. Fixes #5872.
Test plan
CI builds should pass.