fix(resolution): WIP: Improve dependency resolution performance (comparison of #5970) #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of continuing to re-resolve a package in the dependency tree that has already been resolved, add a request to the existing references requests array. This speeds up very deep/complex dep trees as seen in workspaces where the workspace modules all depend on each other. Previously the building of the tree was leading to out of memory errors or just never finishing. fixes yarnpkg#5726 yarnpkg#5628
…ixes logic error when a dep is referenced as both a normal and an optional dependency.
hulkish
commented
Jun 13, 2018
| @@ -279,9 +276,11 @@ export default class Config { | |||
| }); | |||
|
|
|||
| this.registries[key] = registry; | |||
| this.registryFolders.push(registry.folder); | |||
| if (this.registryFolders.indexOf(registry.folder) === -1) { | |||
There was a problem hiding this comment.
this fixes an issue i was seeing where value of registryFolders was ['node_modules', 'node_modules'] - which I think was causing double lookups for ignorePatterns.
hulkish
changed the title
hulkish
force-pushed
the
improve-resolution-performance
branch
from
302fd5a
to
ac8e244
Compare
|
@rally25rs another thing I'm noticing here... For workspace packages - there should not be a fetch request for these. It should just prefer the local link. |
|
@arcanis any change to get this or the related pull request reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant as a WIP pr to compare with #5970