Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #612
This does not call
github.authenticate()
if there is no token provided. Maybe even removing the call at all now that yarn is OS?This only fixes the authentication issue, after I fixed this it seems yarn is trying to download an rpm file on my mac. Going to look into this next.
Test plan
Well, there are tests for self-update but seems they are disabled. I try to disable them in the upcoming PR :)