Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ignore engines flag. #647

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Respect ignore engines flag. #647

merged 1 commit into from
Oct 11, 2016

Conversation

samccone
Copy link
Member

Test plan

package.json

{
  "dependencies": {
  "cosmiconfig": "2.0.1"
  }
}

yarn install

Fails
...

yarn install --ignore-flags

works

Fixes #638

@bestander
Copy link
Member

@samccone would you mind fixing lint?

src/package-compatibility.js:101
101:     this.ignoreEngines = ignoreEngines;
         ^^^^^^^^^^^^^^^^^^ assignment of property `ignoreEngines`
101:     this.ignoreEngines = ignoreEngines;
              ^^^^^^^^^^^^^ property `ignoreEngines`. Property not found in
 96: export default class PackageCompatibility {
                          ^^^^^^^^^^^^^^^^^^^^ PackageCompatibility

@samccone
Copy link
Member Author

done @bestander 🐐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants