Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fail when upgrading incompatible optional dependencies #6510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katakonst
Copy link

@katakonst katakonst commented Oct 6, 2018

Summary
This was caused by setting the optional field to false.This is fixed by searching if the optional dependency exists in manifest.

fixes #5471

@arcanis
Copy link
Member

arcanis commented Nov 5, 2018

Hey @katakonst! Sorry for the delay - can you please add a test? I'll then merge it for the 1.13 release (scheduled in two weeks from now, I'd say).

@buildsize
Copy link

buildsize bot commented Nov 6, 2018

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.1 MB 1.1 MB -1.56 KB (0%)
yarn-[version].js 4.46 MB 4.46 MB 102 bytes (0%)
yarn-legacy-[version].js 4.65 MB 4.63 MB -17.26 KB (0%)
yarn-v[version].tar.gz 1.11 MB 1.11 MB -1.84 KB (0%)
yarn_[version]all.deb 813.46 KB 812.6 KB -886 bytes (0%)

@katakonst
Copy link
Author

Added a test!

@kristian
Copy link

Will likely also fix #6526. Could this one be merged w/ the next release? A review is still pending. Thanks.

@dylanmerrick
Copy link

Any chance this can go in? It's been sitting idle for a while...

@kristian
Copy link

kristian commented Mar 31, 2022

@arcanis any update here? Still we cannot use / switch to Yarn 2, because we have the issue that some of our optional dependencies do not exist in some of our repositories, and we need the install to not fail (which atm. it still does).

Update: Sorry I just saw this is for Yarn 1. I will open the same issue in the berry repository.

@kristian
Copy link

I did create follow-up ticket: yarnpkg/berry#4306 in the https://github.com/yarnpkg/berry/ repository. Please let me know if I should suggest a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"yarn upgrade --latest" fails if optionalDependencies contains incompatible dependencies
4 participants