New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fail when upgrading incompatible optional dependencies #6510
base: master
Are you sure you want to change the base?
Conversation
Hey @katakonst! Sorry for the delay - can you please add a test? I'll then merge it for the 1.13 release (scheduled in two weeks from now, I'd say). |
78612c5
to
209358c
Compare
|
Added a test! |
Will likely also fix #6526. Could this one be merged w/ the next release? A review is still pending. Thanks. |
Any chance this can go in? It's been sitting idle for a while... |
@arcanis any update here? Still we cannot use / switch to Yarn 2, because we have the issue that some of our optional dependencies do not exist in some of our repositories, and we need the install to not fail (which atm. it still does). Update: Sorry I just saw this is for Yarn 1. I will open the same issue in the berry repository. |
I did create follow-up ticket: yarnpkg/berry#4306 in the https://github.com/yarnpkg/berry/ repository. Please let me know if I should suggest a PR to fix it. |
Summary
This was caused by setting the optional field to false.This is fixed by searching if the optional dependency exists in manifest.
fixes #5471