Fix for devDependencies not upgrading within a workspace #6943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4971
Summary
Performing a
yarn add <dependency>
within a workspace adds a new version todependencies
in the package.json instead of upgrading the version indevDependencies
.Test plan
yarn workspace package1 [add/upgrade] [dependencyName]
cd package1
thenyarn [add/upgrade] [dependencyName]
Notes
Alternatively, removing this
if
statement would fix the issue as well:yarn/src/cli/commands/install.js
Lines 357 to 362 in fb03788