Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write cache path into yarn.lock for nested file dependencies #7042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sokki
Copy link

@sokki sokki commented Feb 18, 2019

Summary

Solves #4388
Based on #4717

The linked issue is unresolved for over a year now. It seems like solving the root cause of this issue by bypassing the cache for file-dependencies would require too much refactoring of the underlying architecture. At least I got lost while trying to do so 馃檭

So I chose this rather naive approach. All tests pass and I've tested it in a bigger monorepo where we regularly faced this issue.

Test plan
What was written to yarn.lock before:
image

@buildsize
Copy link

buildsize bot commented Feb 18, 2019

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.11聽MB 1.11聽MB 567聽bytes (0%)
yarn-[version].js 4.47聽MB 4.47聽MB 1.33聽KB (0%)
yarn-legacy-[version].js 4.66聽MB 4.66聽MB 1.57聽KB (0%)
yarn-v[version].tar.gz 1.12聽MB 1.12聽MB 97聽bytes (0%)
yarn_[version]all.deb 815.67聽KB 815.75聽KB 76聽bytes (0%)

@arcanis
Copy link
Member

arcanis commented Mar 8, 2019

The 1.15 will have a fair amount of changes already, so I'd like to postpone this to the 1.16 if you don't mind (since it might have unseen side effects) 馃槂

@sokki
Copy link
Author

sokki commented Mar 12, 2019

Sure. As long as we don't have to wait for berry 馃檭

@arcanis
Copy link
Member

arcanis commented Mar 12, 2019

Nope, no worry, I keep merging PRs over here 馃槈

@krigar1184
Copy link

Any chance for this to be merged any time soon?

@desaiuditd
Copy link

@arcanis When this PR is scheduled to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants