Make yarn link collision message display existing link path #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
requested changes
Apr 29, 2019
| @@ -58,7 +58,8 @@ export async function run(config: Config, reporter: Reporter, flags: Object, arg | |||
|
|
|||
| const linkLoc = path.join(config.linkFolder, name); | |||
| if (await fs.exists(linkLoc)) { | |||
| reporter.warn(reporter.lang('linkCollision', name)); | |||
| const linkTarget = await fs.readlink(linkLoc); | |||
| reporter.warn(reporter.lang('linkCollision', name, linkTarget)); | |||
There was a problem hiding this comment.
I think we can improve the message even further by using path.resolve to have an absolute path rather than a relative path, what do you think?
| @@ -72,7 +73,8 @@ export async function run(config: Config, reporter: Reporter, flags: Object, arg | |||
| const binSrcLoc = path.join(linkLoc, binSrc); | |||
| const binDestLoc = path.join(globalBinFolder, binName); | |||
| if (await fs.exists(binDestLoc)) { | |||
| reporter.warn(reporter.lang('binLinkCollision', binName)); | |||
| const binDestLinkTarget = await fs.readlink(binDestLoc); | |||
| reporter.warn(reporter.lang('binLinkCollision', binName, binDestLinkTarget)); | |||
|
Rebase/merge, then add slightly better message in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
yarn linkfor a package whose name collides with an existing link spits out a rather unhelpful warning:This PR causes the message to include the path to which the existing link points, as well as removing the "If this command was run in..." sentence, as this command has to have already been run in another folder for this message to show up in the first place.
Output
This PR fixes #7054