-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(E2BIG): Ignore potentially large vscode keys #7419
Conversation
@BYK I submitted the simple version. Wasn't sure where a warning should really go -- directly here: https://github.com/eamodio/yarn/blob/dfe97900ca5f425d8cf303477b66073f4f6cb812/src/util/execute-lifecycle-script.js#L104? |
I think this version is fine since you did not add dropping random stuff based on their sizes. I'll leave the final say to @arcanis. Btw. I think you need to update some tests or add new ones :) |
Updated with lint fixes -- oops 😄 |
|
Sounds all good to me! |
Hahaha sorry, my bad. I forgot my own refactor making this test future-proof :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Hooray! Thank you! |
@eamodio not sure about the next release but if you need it, you can use the nightly builds safely as a release is just a tagged version of those (and some packaging magic). |
Summary
Ignores 2 VS Code extension specific
package.json
keys that tend to get large and can cause E2BIG errors. I just moved my vscode extension (GitLens) fromnpm
toyarn
hoping this issue (a largepackage.json
) wouldn't manifest itself, but sadly it was still an issue.Here is the original issue I commented on: #5420 (comment)
Fixes #5420 for another instance.