Fix a bug when git padding warning message start with /[a-f]/ #7428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwyc992
force-pushed
the
fix/validRef/regex
branch
from
16028a0
to
f8ba114
Compare
|
rebase upstream to resolve |
rockwyc992
force-pushed
the
fix/validRef/regex
branch
from
f8ba114
to
a6eb73a
Compare
rockwyc992
force-pushed
the
fix/validRef/regex
branch
from
a6eb73a
to
d98d7bb
Compare
rockwyc992
force-pushed
the
fix/validRef/regex
branch
2 times, most recently
from
6600fdf
to
6ca691d
Compare
rockwyc992
force-pushed
the
fix/validRef/regex
branch
2 times, most recently
from
16c155f
to
59f5540
Compare
|
Use wrapper to refactor spawnMock. |
rockwyc992
force-pushed
the
fix/validRef/regex
branch
from
59f5540
to
0706a71
Compare
|
rebase again and again. |
1. resolveDefaultBranch when remote 2. resolveDefaultBranch when remote with 'Identity added' warning message (yarnpkg#5077) 3. resolveDefaultBranch when remote with 'Failed to add the host' warning message (yarnpkg#5013) 4. resolveDefaultBranch when remote with "Warning:" message (yarnpkg#5013) 5. resolveDefaultBranch when remote with 'fatal:' error message (yarnpkg#7239)
rockwyc992
force-pushed
the
fix/validRef/regex
branch
from
0706a71
to
340bb25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #5077 #5013 #7239
The regex filter in #5081 is too simple to match some use case.
If there is a warning message start with
/[a-f]/, it will broken its behavior.Test plan
Modify
spawnGitmock implementation with 5 use case: