Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents cache removal when running an install #7699

Merged
merged 4 commits into from Nov 22, 2019
Merged

Conversation

@arcanis
Copy link
Member

@arcanis arcanis commented Nov 22, 2019

Summary

When running yarn install, Yarn used to remove all dot-folders inside node_modules. This caused performance issues with applications such as Webpack, because they typically use node_modules/.cache as a standard location where to keep their state.

This diff prevents Yarn from ever removing dot-folders stored within a node_modules.

Fixes #7683

Test plan

Added tests.

@arcanis arcanis merged commit 98d51d8 into master Nov 22, 2019
10 of 19 checks passed
arcanis added a commit that referenced this issue Nov 22, 2019
* Prevents cache removal when running an install

* Removes .bin as usual

* Update CHANGELOG.md
VincentBailly pushed a commit to VincentBailly/yarn that referenced this issue Jun 10, 2020
* Prevents cache removal when running an install

* Removes .bin as usual

* Update CHANGELOG.md
VincentBailly added a commit to VincentBailly/yarn that referenced this issue Jun 10, 2020
* Prevents cache removal when running an install

* Removes .bin as usual

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant