bugfix #4884 On FreeBSD read(2) can read directories. Detect them before read. #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(2) a directory, getting some binary data representing it. Code in yarn assumes the OS returns EISDIR when reading a directory. I added a fix which checks if the file is actually a directory before reading it, which should work everywhere.
Actually this does not look necessary, since I'm not changing behavior. |
When a directory is found, directly return an empty object instead of throwing an error causing the roundtrip through catch.
madpilot78
changed the title
madpilot78
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for issue #4884 which shows up on FreeBSD and other OSes where it is possible to read(2) a directory (depending on the filesystem actually) and get back some binary representation of it.
This causes yarn to file as described in issue #4884.
In the FreeBSD ports tree we are installing yarn with another patch fundamentally backing out commit 2cb2fc4. This is suboptimal, also because we are patching the compiled bundle at present. Having a proper fix included upstream would be great.
I'll update the CHANGELOG in a new commit on this same pull request shortly.
Test plan
I tested it locally by checking that the same operations failing with a clean install are not happening with the new bundle.