Fix git dependencies with slashes inside branch name #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, branches with slashes such as
features/feature-branchwould not be recognized by the package resolver. This happened because ref names (e.g.refs/heads/features/feature-branch) were not parsed correctly. Instead of looking at everything after the second slash, it only looked at the string after the second slash and before the third. This resulted inrefs/heads/features/feature-branchbeing parsed tofeaturesinstead offeatures/feature-branch.Test plan
I have added a test case to
__tests__/package-resolver.jsthat tries to parsehttps://github.com/babel/babel-loader.git#feature/sourcemaps. Previously, this caused an error. This has been fixed now.There is one more failing test though, but I'm sure it's not related to my change. Tests seem to be always failing for this project right now.