Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greyepoxy/handle scoped packages being hoisted #8318

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

greyepoxy
Copy link
Contributor

Summary

Fixes #8302

Test plan

Validated that the reproduction listed in the issue was fixed

@greyepoxy
Copy link
Contributor Author

I have been attempting to fix the CI and so far have not had any luck. Looks like my new test is consistently failing but only on CI.

Locally on windows 10 I see it passing consistently (tried with node versions 12.18.3, 10.22.0, and 8.17.0, both 32 and 64 bit versions).

Looks like path length "might" be the cause (I was seeing the same CI failure locally with the original longer dependency names) but even after shortening them and double checking through console logs that no file path in the test directory was over 240 characters, I still see the CI failing.

At this point I am not sure how to proceed, looks to me like the yarn add is silently failing to replace directories in the test's node_modules but its unclear why that is the case.

Would appreciate assistance

return (await Promise.all(subFiles)).reduce((previous, current) => previous.concat(...current), []);
};
const allFilePathsInTestDirectory = await getAllFilePaths(config.cwd);
config.reporter.info(allFilePathsInTestDirectory.join('\n'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reporter info call was for debugging the CI only, will remove it once the CI is passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn install non-determinism: Yarn does not prune scoped projects in dependent node_modules
1 participant