Update http to support Authorization in header #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Basic Authentication in "Authorization: Basic <base64 hash of user:pass>"
Added examples of Basic Authentication via Auth Token
|
Using this on one of my projects and had to edit a bit since SOAP is not much of a standard, any options i add, i'll pull into here |
|
@levensailor I think you wanted it to be: PS thanks for the update hopefully @yaronn will merge your changes. |
|
Just wanted to also put this here that using the format http://username:password@somedomain.com in the ctx json for the url element may be all that is needed for basic auth. still wouldn't hurt for @levensailor commit to be merged into the project. |
|
+1 for this PR |
|
fixed the formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Authorization option in ctx setup and handling in http module