Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide defaults for config and keyfile #2

Merged
merged 4 commits into from
Nov 28, 2017
Merged

Provide defaults for config and keyfile #2

merged 4 commits into from
Nov 28, 2017

Conversation

sascha-andres
Copy link
Contributor

Default for config: ~/.grapes.yml
Default for key: ~/.ssh/id_rsa

Default for config: ~/.grapes.yml
Default for key: ~/.ssh/id_rsa
@sascha-andres
Copy link
Contributor Author

@yaronsumel I added default values for config and key as best guesses

@yaronsumel
Copy link
Owner

@sascha-andres Thanks for the contribution..

Two things that missing:

  • Change the options description at:
  1. https://github.com/sascha-andres/grapes/blob/0a7197f9c5c635e80b1882d1d9d689da789f9ce8/input.go#L33
  2. https://github.com/sascha-andres/grapes/blob/0a7197f9c5c635e80b1882d1d9d689da789f9ce8/input.go#L34
  • Cover that changes with small test (input_test.go)

@yaronsumel yaronsumel merged commit df84c35 into yaronsumel:master Nov 28, 2017
@yaronsumel
Copy link
Owner

great work .. merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants