Support peer provider plugins #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kriskowal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @prashantv to be a potential reviewer. |
kriskowal
force-pushed
the
pptemp
branch
2 times, most recently
from
a3dd9d3
to
ab4abe6
Compare
|
Fixes #155 |
prashantv
reviewed
Feb 22, 2017
peerprovider/interface.go
Outdated
| RegisterPeerProvider("file", filePeerProvider{}) | ||
| } | ||
|
|
||
| // Schemes returns supported peer provider protocol schemes. |
There was a problem hiding this comment.
Can we add unit tests in this package for:
- registering a new scheme
- making sure it's returned in
Schemes - ensuring it's used when
Resolveis called with that scheme
transport.go
Outdated
| // Paths are a strict subset of the URL file protocol scheme. We | ||
| // explicate the file protocol as a key into the peer provider | ||
| // registry. | ||
| if u.Scheme == "" { |
There was a problem hiding this comment.
Could we register the file provider under the "" scheme and have this work without this if?
| @@ -241,6 +242,13 @@ func parseDefaultConfigs(parser *flags.Parser) error { | |||
| } | |||
|
|
|||
| func runWithOptions(opts Options, out output) { | |||
| if opts.TOpts.HostPortFile == "?" { | |||
There was a problem hiding this comment.
we can unit test this in, main_test.go has some integration tests that should have examples of how to do this.
prashantv
approved these changes
Feb 23, 2017
| func TestResolveError(t *testing.T) { | ||
| oldRegistry := registry | ||
| defer func() { registry = oldRegistry }() | ||
| registry = make(map[string]PeerProvider) |
There was a problem hiding this comment.
optionally: make a helper for this,
func stubRegister() func() {
oldRegistry := registry
registry = make(map[string]PeerProvider)
return func() { registry = oldRegistry }()
}
func TestResolveError(t *testing.T) {
defer stubRegistry()()
[...]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change factors out a pluggable peer provider registry and extends the meaning of the
-Pflag to be a URI, currently only supporting the implicit or explicitfile:/protocol scheme.