templateargs: Deal with YAML's handling of "y" as boolean #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using yab templates and a key is specified as `"y"` (with quoting), the template parsing ends up converting this to `y`, which then gets unmarshalled as a boolean. The underlying cause is: go-yaml/yaml#214 This is caused by template rendering's use of `yaml.Unmarshal` on all string values which can lose the type. This change restricts the `Unmarshal` to values that were modified as part of the rendering step. It also adds special logic to protect against YAML's boolean handling, by only using the boolean value if strconv.ParseBool would parse the value. This means if a value was rendered as `y`, we would still not treat it as a boolean. Fixes #253
Codecov Report
@@ Coverage Diff @@
## dev #254 +/- ##
==========================================
+ Coverage 94.04% 94.09% +0.05%
==========================================
Files 43 43
Lines 2366 2371 +5
==========================================
+ Hits 2225 2231 +6
+ Misses 88 87 -1
Partials 53 53
Continue to review full report at Codecov.
|
abhinav
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using yab templates and a key is specified as
"y"(with quoting),the template parsing ends up converting this to
y, which then getsunmarshalled as a boolean. The underlying cause is:
go-yaml/yaml#214
This is caused by template rendering's use of
yaml.Unmarshalon allstring values which can lose the type.
This change restricts the
Unmarshalto values that were modifiedas part of the rendering step. It also adds special logic to protect
against YAML's boolean handling, by only using the boolean value
if strconv.ParseBool would parse the value. This means if a value
was rendered as
y, we would still not treat it as a boolean.Fixes #253