Merge 2943e4c into 1d8bf3a

yarpc · Dec 7, 2016 · 05311f9 · 05311f9
2 parents 1d8bf3a + 2943e4c
commit 05311f9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/transport/http/inbound.go b/transport/http/inbound.go
@@ -66,13 +66,6 @@ func (i *Inbound) WithTracer(tracer opentracing.Tracer) *Inbound {
 	return i
 }
 
-// WithRegistry configures a registry to handle incoming requests,
-// as a chained method for convenience.
-func (i *Inbound) WithRegistry(registry transport.Registry) *Inbound {
-	i.registry = registry
-	return i
-}
-
 // SetRegistry configures a registry to handle incoming requests.
 // This satisfies the transport.Inbound interface, and would be called
 // by a dispatcher when it starts.

diff --git a/transport/http/inbound_test.go b/transport/http/inbound_test.go
@@ -85,9 +85,9 @@ func TestInboundStartAndStop(t *testing.T) {
 
 func TestInboundStartError(t *testing.T) {
 	x := NewTransport()
-	err := x.NewInbound("invalid").
-		WithRegistry(new(transporttest.MockRegistry)).
-		Start()
+	i := x.NewInbound("invalid")
+	i.SetRegistry(new(transporttest.MockRegistry))
+	err := i.Start()
 	assert.Error(t, err, "expected failure")
 }
 

diff --git a/transport/tchannel/inbound.go b/transport/tchannel/inbound.go
@@ -65,13 +65,6 @@ func (i *Inbound) WithTracer(tracer opentracing.Tracer) *Inbound {
 	return i
 }
 
-// WithRegistry configures a registry to handle incoming requests,
-// as a chained method for convenience.
-func (i *Inbound) WithRegistry(registry transport.Registry) *Inbound {
-	i.registry = registry
-	return i
-}
-
 // SetRegistry configures a registry to handle incoming requests.
 // This satisfies the transport.Inbound interface, and would be called
 // by a dispatcher when it starts.