Skip to content

Commit

Permalink
Merge 2943e4c into 1d8bf3a
Browse files Browse the repository at this point in the history
  • Loading branch information
kriskowal committed Dec 7, 2016
2 parents 1d8bf3a + 2943e4c commit 05311f9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 17 deletions.
7 changes: 0 additions & 7 deletions transport/http/inbound.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,6 @@ func (i *Inbound) WithTracer(tracer opentracing.Tracer) *Inbound {
return i
}

// WithRegistry configures a registry to handle incoming requests,
// as a chained method for convenience.
func (i *Inbound) WithRegistry(registry transport.Registry) *Inbound {
i.registry = registry
return i
}

// SetRegistry configures a registry to handle incoming requests.
// This satisfies the transport.Inbound interface, and would be called
// by a dispatcher when it starts.
Expand Down
6 changes: 3 additions & 3 deletions transport/http/inbound_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ func TestInboundStartAndStop(t *testing.T) {

func TestInboundStartError(t *testing.T) {
x := NewTransport()
err := x.NewInbound("invalid").
WithRegistry(new(transporttest.MockRegistry)).
Start()
i := x.NewInbound("invalid")
i.SetRegistry(new(transporttest.MockRegistry))
err := i.Start()
assert.Error(t, err, "expected failure")
}

Expand Down
7 changes: 0 additions & 7 deletions transport/tchannel/inbound.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ func (i *Inbound) WithTracer(tracer opentracing.Tracer) *Inbound {
return i
}

// WithRegistry configures a registry to handle incoming requests,
// as a chained method for convenience.
func (i *Inbound) WithRegistry(registry transport.Registry) *Inbound {
i.registry = registry
return i
}

// SetRegistry configures a registry to handle incoming requests.
// This satisfies the transport.Inbound interface, and would be called
// by a dispatcher when it starts.
Expand Down

0 comments on commit 05311f9

Please sign in to comment.