Review nit + using proper logger...

yarpc · Sep 9, 2016 · 8bb3d0e · 8bb3d0e
1 parent e84805b
commit 8bb3d0e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/transport/http/handler.go b/transport/http/handler.go
@@ -22,12 +22,11 @@ package http
 
 import (
 	"fmt"
+	"log"
 	"net/http"
 	"runtime/debug"
 	"time"
 
-	"code.uber.internal/go-common.git/x/log"
-
 	"github.com/yarpc/yarpc-go/internal/baggage"
 	"github.com/yarpc/yarpc-go/internal/errors"
 	"github.com/yarpc/yarpc-go/internal/request"
@@ -111,7 +110,7 @@ func (h handler) callHandler(w http.ResponseWriter, req *http.Request, start tim
 	// We recover panics from the user handler.
 	defer func() {
 		if r := recover(); r != nil {
-			log.Errorf("Handler panicked: %v\n%s", r, debug.Stack())
+			log.Printf("Handler panicked: %v\n%s", r, debug.Stack())
 			returnErr = fmt.Errorf("panic: %v", r)
 		}
 	}()

diff --git a/transport/http/handler_test.go b/transport/http/handler_test.go
@@ -295,8 +295,7 @@ func TestHandlerInternalFailure(t *testing.T) {
 
 type panickedHandler struct{}
 
-func (th panickedHandler) Handle(context.Context, transport.Options,
-	*transport.Request, transport.ResponseWriter) error {
+func (th panickedHandler) Handle(context.Context, transport.Options, *transport.Request, transport.ResponseWriter) error {
 	panic("oops I panicked!")
 }
 

diff --git a/transport/tchannel/handler.go b/transport/tchannel/handler.go
@@ -22,11 +22,10 @@ package tchannel
 
 import (
 	"fmt"
+	"log"
 	"runtime/debug"
 	"time"
 
-	"code.uber.internal/go-common.git/x/log"
-
 	"github.com/yarpc/yarpc-go/internal/encoding"
 	"github.com/yarpc/yarpc-go/internal/errors"
 	"github.com/yarpc/yarpc-go/internal/request"
@@ -164,7 +163,7 @@ func (h handler) callHandler(ctx context.Context, call inboundCall, now time.Tim
 	// We recover panics from the user handler.
 	defer func() {
 		if r := recover(); r != nil {
-			log.Errorf("Handler panicked: %v\n%s", r, debug.Stack())
+			log.Printf("Handler panicked: %v\n%s", r, debug.Stack())
 			returnErr = fmt.Errorf("panic: %v", r)
 		}
 	}()