Address feedback

transport/tchannel/channel_outbound_test.go

@@ -110,7 +110,8 @@ func TestChannelOutboundHeaders(t *testing.T) {
 
 							err = writeArgs(call.Response(), []byte{0x00, 0x00}, []byte("bye!"))
 							assert.NoError(t, err, "failed to write response")
-						}))
+						},
+					))
 
 					out, err := constructor.new(testutils.NewClient(t, &testutils.ChannelOpts{
 						ServiceName: "caller",

transport/tchannel/inbound.go

@@ -37,25 +37,16 @@ func (i *Inbound) Transports() []transport.Transport {
 	return []transport.Transport{i.transport}
 }
 
-// Channel returns the underlying Channel for this Inbound.
-func (i *Inbound) Channel() Channel {
-	return i.transport.ch
-}
-
 // Start starts this Inbound. Note that this does not start listening for
 // connections; that occurs when you start the underlying ChannelTransport is
 // started.
 func (i *Inbound) Start() error {
-	return i.once.Start(func() error {
-		return nil // Nothing to do
-	})
+	return i.once.Start(nil)
 }
 
 // Stop stops the TChannel outbound. This currently does nothing.
 func (i *Inbound) Stop() error {
-	return i.once.Stop(func() error {
-		return nil // Nothing to do
-	})
+	return i.once.Stop(nil)
 }
 
 // IsRunning returns whether the Inbound is running.

transport/tchannel/outbound.go

@@ -158,14 +158,14 @@ func (o *Outbound) Transports() []transport.Transport {
 // Start starts the TChannel outbound.
 func (o *Outbound) Start() error {
 	return o.once.Start(func() error {
-		return nil // Nothing to do
+		return o.chooser.Start()
 	})
 }
 
 // Stop stops the TChannel outbound.
 func (o *Outbound) Stop() error {
 	return o.once.Stop(func() error {
-		return nil // Nothing to do
+		return o.chooser.Stop()
 	})
 }