Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require encoding on the wire #238

Closed
HelloGrayson opened this issue Jun 27, 2016 · 0 comments
Closed

Require encoding on the wire #238

HelloGrayson opened this issue Jun 27, 2016 · 0 comments
Assignees
@abhinav
Milestone
Finalize API

Comments

@HelloGrayson
Copy link
Contributor

Currently, the encoding param is not required on the wire. If we want to make it required, we should act now since it would be a transport-level breaking change. cc #232

Thoughts?
@HelloGrayson HelloGrayson added this to the Finalize API milestone Jun 27, 2016
@HelloGrayson HelloGrayson mentioned this issue Jul 13, 2016
Closed
@abhinav abhinav mentioned this issue Jul 26, 2016
Merged
@abhinav abhinav self-assigned this Jul 26, 2016
abhinav added a commit that referenced this issue Jul 26, 2016
@abhinav
Require encoding over the wire (#279)
7c120ea 
This changes yarpc-go to require the encoding over the wire. Incoming requests
are considered bad requests if they don't have an encoding or if the encoding
does not match the encoding on the handler.

Resolves #238

Related: yarpc/yarpc-node#77 yarpc/yarpc-python#88 yarpc/yarpc-java#121
@abhinav abhinav mentioned this issue Aug 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinav abhinav

Labels
None yet
Milestone
Finalize API
Development

No branches or pull requests
2 participants
@abhinav @HelloGrayson