[Peer] Adjust choose interface to return a onFinish closure #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willhug, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kriskowal, @AlexAPB and @abhinav to be potential reviewers. |
willhug
force-pushed
the
adjustchoosepeer-part_1.0
branch
from
59ddfe8
to
d641bf0
Compare
kriskowal
approved these changes
Dec 8, 2016
| } | ||
|
|
||
| for { | ||
| if nextPeer := pl.nextPeer(); nextPeer != nil { | ||
| pl.notifyPeerAvailable() | ||
| return nextPeer, nil | ||
| nextPeer.StartRequest(pl) | ||
| return nextPeer, pl.getOnFinishFunc(nextPeer), nil |
There was a problem hiding this comment.
We should cache this on the ring next to the node it effects.
willhug
force-pushed
the
adjustchoosepeer-part_1.0
branch
from
d641bf0
to
771453b
Compare
willhug
force-pushed
the
adjustchoosepeer-part_1.0
branch
from
771453b
to
f946d8c
Compare
willhug
changed the base branch from
_start_-adjustchoosepeer-part_1.0
to
dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: in #472 we defined a new interface for having safer onfinish changes. This diff performs the change to the interface