Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed heap memory allocation for scan/select header mangling #16

Merged
merged 5 commits into from Apr 5, 2019

Conversation

yashNaN
Copy link
Owner

@yashNaN yashNaN commented Apr 4, 2019

No description provided.

@yashNaN yashNaN added the ReadyForReview This PR is ready for review label Apr 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #16 into schema_change will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           schema_change      #16      +/-   ##
=================================================
- Coverage          90.25%   90.22%   -0.03%     
=================================================
  Files                 82       82              
  Lines               3508     3499       -9     
=================================================
- Hits                3166     3157       -9     
  Misses               342      342
Impacted Files Coverage Δ
src/include/storage/projected_row.h 100% <ø> (ø) ⬆️
src/include/storage/sql_table.h 100% <ø> (ø) ⬆️
src/include/storage/projected_columns.h 100% <ø> (ø) ⬆️
src/storage/sql_table.cpp 85.88% <100%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176763c...018c7c5. Read the comment docs.

@yangjuns yangjuns self-requested a review April 5, 2019 00:06
Copy link
Collaborator

@yangjuns yangjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashNaN yashNaN merged commit bd4739a into schema_change Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyForReview This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants