Add Scan benchmark #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2019 22:36
jrolli
approved these changes
Apr 9, 2019
| for (auto _ : state) { | ||
| uint32_t tuples_read = 0; | ||
| auto start_pos = table_->begin(storage::layout_version_t(0)); | ||
| while (tuples_read != num_inserts_) { |
There was a problem hiding this comment.
Why are we using this conditional rather than the more canonical “!= table_.end()” construct?
Codecov Report
@@ Coverage Diff @@
## schema_change #23 +/- ##
==============================================
Coverage 89.32% 89.32%
==============================================
Files 118 118
Lines 4610 4610
==============================================
Hits 4118 4118
Misses 492 492
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingleVersionScan
MultiVersionScan