Peer Review Edits #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Abstract and Aggregate expression * Remove unnecessary check * Add expression types to switch statement * Parameter Value Expression JSON (de)serialization * Add JSON declaration macro to ParameterValueExpression * Serialization for TupleValueExpression * Fix tidy * FunctionExpression, OperatorExpression * TypeCastExpression * case expr * Change to use safer .at() json method * ConstantValueExpression serialization (Wen) * Fixes with ConstantValueExpression * CompareExpression json (de)serialization * Add ConjunctionExpression * SubqueryExpression (needs fixing) * Change AbstractExpression Copy to use shared_ptr * Change Copy on expressions to use shared_ptr * rename Parameter to BaseFunctionParameter * Add Subquery Expression serialization and general fixes * Improve test coverage
- Comment: cmu-db#342 (comment)
- Comment: cmu-db#342 (comment)
- Comment: cmu-db#342 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address minor issues identified during the peer review. A link to the specific review comment is hyperlinked in each of the individual commits.