New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values #28
Default values #28
Conversation
Codecov Report
@@ Coverage Diff @@
## schema_change #28 +/- ##
=================================================
+ Coverage 88.11% 88.17% +0.05%
=================================================
Files 190 190
Lines 7242 7287 +45
=================================================
+ Hits 6381 6425 +44
- Misses 861 862 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code to apply default values looks clean, but I think the code applies default values in cases where it shouldn't. A test suite just for default values would help keep us on track.
…ltValueMap for SqlTable should fix this
Default values for MV tables. Fixes #24
PS: My C++ is pretty bad! So please feel free to suggest improvements.