Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed some pr comments #40

Merged
merged 1 commit into from May 12, 2019
Merged

Addressed some pr comments #40

merged 1 commit into from May 12, 2019

Conversation

yashNaN
Copy link
Owner

@yashNaN yashNaN commented May 12, 2019

Addressing a few of the pull request fixes

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #40 into schema_change will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           schema_change     #40      +/-   ##
================================================
+ Coverage          88.17%   88.2%   +0.02%     
================================================
  Files                190     190              
  Lines               7292    7292              
================================================
+ Hits                6430    6432       +2     
+ Misses               862     860       -2
Impacted Files Coverage Δ
src/include/storage/sql_table.h 96.22% <ø> (ø) ⬆️
src/include/storage/storage_defs.h 94.44% <ø> (ø) ⬆️
src/storage/sql_table.cpp 96.15% <100%> (ø) ⬆️
src/transaction/transaction_manager.cpp 95.27% <0%> (+0.78%) ⬆️
src/storage/garbage_collector.cpp 95.23% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cca570...505a010. Read the comment docs.

@jrolli jrolli merged commit 8d22128 into schema_change May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants